Skip to content

Rollup of 4 pull requests#150342

Closed
JonathanBrouwer wants to merge 9 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-r5g9by1
Closed

Rollup of 4 pull requests#150342
JonathanBrouwer wants to merge 9 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-r5g9by1

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 24, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ChrisDenton and others added 9 commits December 24, 2025 06:41
@ChrisDenton
Avoid using env::temp when linking a binary
b5c473e 
This keeps all build artefacts (even temporary ones) within the build directory.
@ChrisDenton
Rename invalid-tmpdir-env-var
6e35454 
to invalid-tmpdir-no-ice
@heiher
Disable f16 on LoongArch for LLVM < 21
855281c 
The `f16` type works on the LoongArch target starting from LLVM 21.
However, the current minimum supported external LLVM version is 20,
so `f16` must not be enabled on LoongArch for LLVM version < 21.
@bjorn3
Include rustc version in ICE messages
13c6256 
Rather than only including them in the ICE file. Not every user includes
the ICE file in their bug reports, nor do they always list the rustc
version.
@bjorn3
Fix some divergences with the cg_clif subtree
a3dc0ef 
For some reason git-subtree incorrectly synced those changes.
@JonathanBrouwer
Rollup merge of rust-lang#150311 - ChrisDenton:no-temp, r=Kivooeo
25c4fb3 
Avoid using env::temp when linking a binary

This keeps all build artefacts (even temporary ones) within the build directory.

Fixes rust-lang#139963
@JonathanBrouwer
Rollup merge of rust-lang#150336 - heiher:loong-no-f16-llvm20, r=lqd
cba038f 
Disable f16 on LoongArch for LLVM < 21

The `f16` type works on the LoongArch target starting from LLVM 21. However, the current minimum supported external LLVM version is 20, so `f16` must not be enabled on LoongArch for LLVM version < 21.
@JonathanBrouwer
Rollup merge of rust-lang#150338 - bjorn3:ice_message_version, r=lqd,…
2256059 
…hkBst

Include rustc version in ICE messages

Rather than only including them in the ICE file. Not every user includes the ICE file in their bug reports, nor do they always list the rustc version.
@JonathanBrouwer
Rollup merge of rust-lang#150341 - bjorn3:fix_cg_clif_divergence, r=b…
240750d 
…jorn3

Fix some divergences with the cg_clif subtree

For some reason git-subtree incorrectly synced those changes.

r? `@ghost`

`@rustbot` label +A-codegen +A-cranelift +T-compiler
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 24, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 24, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

📌 Commit 240750d has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2025
@bors
Copy link
Collaborator

bors commented Dec 24, 2025

⌛ Testing commit 240750d with merge 8bdb7d3...

bors added a commit that referenced this pull request Dec 24, 2025
@bors
Auto merge of #150342 - JonathanBrouwer:rollup-r5g9by1, r=JonathanBro…
8bdb7d3 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150311 (Avoid using env::temp when linking a binary)
 - #150336 (Disable f16 on LoongArch for LLVM < 21)
 - #150338 (Include rustc version in ICE messages)
 - #150341 (Fix some divergences with the cg_clif subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 24, 2025

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 

error: `align_of` is not yet stable as a const intrinsic
##[error]   --> example/mini_core.rs:733:26
    |
733 |     const ALIGN: usize = intrinsics::align_of::<Self>();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: add `#![feature(rustc_private)]` to the crate attributes to enable
    |
 17 + #![feature(rustc_private)]
    |

error: aborting due to 2 previous errors

"/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/dist/rustc-clif" "-Csymbol-mangling-version=v0" "-Zannotate-moves" "-Zrandomize-layout" "-Zunstable-options" "--check-cfg=cfg(bootstrap)" "-Zmacro-backtrace" "-Csplit-debuginfo=off" "-Clink-arg=-L/usr/lib/llvm-20/lib" "-Cllvm-args=-import-instr-limit=10" "-Clink-args=-Wl,-z,origin" "-Clink-args=-Wl,-rpath,$ORIGIN/../lib" "-Alinker-messages" "-L" "crate=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/example" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/example" "-Cdebuginfo=2" "--target" "aarch64-unknown-linux-gnu" "-Cpanic=abort" "--check-cfg=cfg(jit)" "--edition=2024" "example/mini_core.rs" "--crate-type" "lib,dylib" exited with status ExitStatus(unix_wait_status(256))
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Command `/checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo run --target aarch64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout --locked --color=always --release --manifest-path /checkout/compiler/rustc_codegen_cranelift/build_system/Cargo.toml -- test --download-dir /checkout/obj/build/cg_clif_download --out-dir /checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot [workdir=/checkout/compiler/rustc_codegen_cranelift]` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/test.rs:3853:25
Executed at: src/bootstrap/src/core/build_steps/test.rs:3898:26

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:28:15
  local time: Wed Dec 24 13:14:53 UTC 2025
  network time: Wed, 24 Dec 2025 13:14:53 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 24, 2025

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 

error: `align_of` is not yet stable as a const intrinsic
##[error]   --> example/mini_core.rs:733:26
    |
733 |     const ALIGN: usize = intrinsics::align_of::<Self>();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: add `#![feature(rustc_private)]` to the crate attributes to enable
    |
 17 + #![feature(rustc_private)]
    |

error: aborting due to 2 previous errors

"/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/dist/rustc-clif" "-Csymbol-mangling-version=v0" "-Zannotate-moves" "-Zrandomize-layout" "-Zunstable-options" "--check-cfg=cfg(bootstrap)" "-Zmacro-backtrace" "-Csplit-debuginfo=off" "-Clink-arg=-L/usr/lib/llvm-20/lib" "-Cllvm-args=-import-instr-limit=10" "-Clink-args=-Wl,-z,origin" "-Clink-args=-Wl,-rpath,$ORIGIN/../lib" "-Alinker-messages" "-L" "crate=/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/example" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif/build/example" "-Cdebuginfo=2" "--target" "aarch64-unknown-linux-gnu" "-Cpanic=abort" "--check-cfg=cfg(jit)" "--edition=2024" "example/mini_core.rs" "--crate-type" "lib,dylib" exited with status ExitStatus(unix_wait_status(256))
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Command `/checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo run --target aarch64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout --locked --color=always --release --manifest-path /checkout/compiler/rustc_codegen_cranelift/build_system/Cargo.toml -- test --download-dir /checkout/obj/build/cg_clif_download --out-dir /checkout/obj/build/aarch64-unknown-linux-gnu/stage2-codegen/cg_clif --no-unstable-features --use-backend cranelift --sysroot llvm --skip-test testsuite.extended_sysroot [workdir=/checkout/compiler/rustc_codegen_cranelift]` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/test.rs:3853:25
Executed at: src/bootstrap/src/core/build_steps/test.rs:3898:26

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:24:13
  local time: Wed Dec 24 13:15:16 UTC 2025
  network time: Wed, 24 Dec 2025 13:15:17 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@bors
Copy link
Collaborator

bors commented Dec 24, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 24, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 24, 2025
Merged
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer @bors @rust-log-analyzer @rustbot @ChrisDenton @heiher @bjorn3